fix: throw instead of aborting when the default audio device module fails to initialize - #276
Merged
devopvoid merged 1 commit intoSep 7, 2026
Conversation
…ails to initialize When no AudioDeviceModule is passed, PeerConnectionFactory lets libwebrtc create the platform default, and libwebrtc aborts the whole process when that module fails to initialize, which happens on hosts without an audio system such as containers and virtual machines. The factory now creates the default module itself, the same way AudioDeviceModule does, so the failure surfaces as an exception that tells the application to pass a module created with AudioLayer.kDummyAudio instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no
AudioDeviceModuleis passed,PeerConnectionFactorylets libwebrtc create the platform default, and libwebrtc aborts the whole process when that module fails to initialize, which happens on hosts without an audio system such as containers and virtual machines; the second half of #228 is one such crash. The factory now creates the default module itself, the same wayAudioDeviceModulealready does for an explicit module, so the failure surfaces as an exception telling the application to pass a module created withAudioLayer.kDummyAudioinstead. A test creates the factory without a module and accepts either outcome except a dead process.